fix: rely on quota to restrict file uploads#1494
Merged
icewind1991 merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
solracsf
force-pushed
the
relyOnQuotaOnly
branch
from
2110c3a to
ccffbdb
Compare
skjnldsv
requested review from
a team,
ArtificialOwl,
CarlSchwan,
come-nc,
leftybournes,
nfebe and
provokateurin
and removed request for
a team
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Makes sense to me, but I think this needs some approval from @sorbaugh or @AndyScherzinger, because it might be something we don't want to change.
This was
linked to
issues
Mar 3, 2026
Member
|
Make sense to me too |
This comment was marked as resolved.
This comment was marked as resolved.
solracsf
force-pushed
the
relyOnQuotaOnly
branch
from
ccffbdb to
1f01538
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> # Conflicts: # lib/Listener/BeforeFileSystemSetupListener.php
icewind1991
force-pushed
the
relyOnQuotaOnly
branch
from
1f01538 to
2d01ca0
Compare
icewind1991
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, when the Guest is created, a 0B quota is assigned.
guests/lib/GuestManager.php
Line 106 in 05e93af
Additionally, user is also placed in a jail (
PERMISSION_READ).This breaks more things than it solves (if any) IMO:
#1060
#1088
#1091
This PR makes files uploads rely on quota:
Main goal: let admins decide if Guests should or not be able to upload files.
Actually, even Quota assignment is broken because...it has no effect, as user is in a read-only jail... 😭
To test, just login as Guest to Talk, Deck and other apps and feel the pain with a lot of things broken!
Enjoy Nextcloud as Guest again once this patch is installed 💯
Fix #1060
Fix #1088
Fix #1091